Added tests for the Review page #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Himani1519
reviewed
May 10, 2024
playwright_test/Tests/Review.spec.ts
Outdated
| expect(is_Finish_Button_disable).toBe(true); | ||
| }) | ||
|
|
||
| test('Test Navigation to all pages', async ({ page }) => { |
There was a problem hiding this comment.
Instead doing Navigation test in one test function, keep them in separate function
Himani1519
reviewed
May 10, 2024
playwright_test/Tests/Review.spec.ts
Outdated
| await page.waitForTimeout(20000); | ||
| planningPage.fillPlanningPageWithRequiredFields(RUNTIME_DIR, ZOWE_WORKSPACE_DIR,ZOWE_EXTENSION_DIR,ZOWE_LOG_DIR,'1',JOB_NAME,JOB_PREFIX,JAVA_HOME,NODE_HOME,ZOSMF_HOST,ZOSMF_PORT,ZOSMF_APP_ID) | ||
| await page.waitForTimeout(20000); | ||
| planningPage.clickValidateLocations() |
There was a problem hiding this comment.
You can also directly move to Review tab, instead going through skip button.
Himani1519
reviewed
May 10, 2024
| @@ -0,0 +1,254 @@ | |||
| import { test, ElectronApplication, expect, _electron as electron } from '@playwright/test'; | |||
There was a problem hiding this comment.
Also You need to add a test case where state of each page should be match with the state of Review page.
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
Signed-off-by: sagar-1310 <[email protected]>
|
New PR: #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments